Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install large contract in parts using smaller bundle-handling contract #5002

Closed
dckc opened this issue Apr 4, 2022 · 2 comments
Closed

install large contract in parts using smaller bundle-handling contract #5002

dckc opened this issue Apr 4, 2022 · 2 comments
Assignees
Labels
cosmic-swingset package: cosmic-swingset enhancement New feature or request Inter-protocol Overarching Inter Protocol Zoe package: Zoe
Milestone

Comments

@dckc
Copy link
Member

dckc commented Apr 4, 2022

What is the Problem Being Solved?

As noted in a comment last week,
a 1.1MB runStake bundle seems to be too big for the current devnet (agorictest-8 tag).

@michaelfig ran into this issue in his efforts to get price oracles on devnet (#3595).

Description of the Design

The current devnet doesn't have the new bundlehash / bundlecap stuff, but we can work around the limitations:

An endoCAS.js contract receives bundle items from a deploy script a few at a time and then does E(zoe).install(...) on the result. (thanks to clues from @kriskowal and help from @michaelfig )

For usage, see runStake-deploy.js

Security Considerations

Any contract can, like this endoCAS.js contract, currently get the zoe service, including the power to install code, from its zcf. @Chris-Hibbert , does that put our plans to keep contract installation permissioned until MN-3 (#4395) at-risk, I wonder? I don't think so.

Test Plan

This is a temporary solution, so I don't expect to maintain it long enough to justify automated tests.

@dckc dckc added enhancement New feature or request Inter-protocol Overarching Inter Protocol cosmic-swingset package: cosmic-swingset labels Apr 4, 2022
@Tartuffo
Copy link
Contributor

Tartuffo commented Apr 6, 2022

@kriskowal is working on something that will obviate this in the long term.

@michaelfig
Copy link
Member

michaelfig commented Apr 11, 2022

Done and landed in agoric-sdk (#5042).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmic-swingset package: cosmic-swingset enhancement New feature or request Inter-protocol Overarching Inter Protocol Zoe package: Zoe
Projects
None yet
Development

No branches or pull requests

3 participants