Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

govern passable data as contract parameter #5533

Open
Chris-Hibbert opened this issue Jun 7, 2022 · 0 comments
Open

govern passable data as contract parameter #5533

Chris-Hibbert opened this issue Jun 7, 2022 · 0 comments
Assignees
@Chris-Hibbert
Labels
enhancement New feature or request Governance Governance security Vaults VaultFactor (née Treasury)

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

Liquidation Terms in the VaultFactory are governed as type UNKNOWN, because there's nothing more suitable.

Description of the Design

PASSABLE_DATA with a legible pattern that could be validated would be more suitable.

Security Considerations

Improves legibility and control of the liquidation contract's terms.

Test Plan

Similar to other governed params, with some validation of pattern matches and mis-matches.
@Chris-Hibbert Chris-Hibbert added enhancement New feature or request security Governance Governance Vaults VaultFactor (née Treasury) labels Jun 7, 2022
@Chris-Hibbert Chris-Hibbert self-assigned this Jun 7, 2022
@Chris-Hibbert Chris-Hibbert mentioned this issue Jun 7, 2022
Open
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chris-Hibbert Chris-Hibbert

Labels
enhancement New feature or request Governance Governance security Vaults VaultFactor (née Treasury)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tartuffo @Chris-Hibbert