correct types for pattern matchers

[turadg]

What is the Problem Being Solved?

While working on this again, documenting .optional would help (https://github.com/Agoric/agoric-sdk/pull/6202/files#r971342637 )

I wondered why code could use it without the type and it's because M.call() returns

agoric-sdk/packages/store/src/types.js

Lines 611 to 612 in 870bd22

	/** @typedef {any} MethodGuardMaker */
	/** @typedef {{ klass: 'methodGuard', callKind: 'sync' | 'async', returnGuard: unknown }} MethodGuard */

Relevant

• Generate TypeScript types from matcher patterns #6160

Description of the Design

No any for pattern matcher types.

Security Considerations

Test Plan

[erights]

FWIW, this is implemented at

agoric-sdk/packages/store/src/patterns/patternMatchers.js

Lines 1537 to 1543 in 9b78628

	optional: (...optArgGuards) => {
	optionalArgGuards === undefined ||
	assert.fail(X`Can only have one set of optional guards`);
	restArgGuard === undefined ||
	assert.fail(X`optional arg guards must come before rest arg`);
	return makeMethodGuardMaker(callKind, argGuards, optArgGuards);
	},

and used several times in https://github.com/Agoric/agoric-sdk/blob/master/packages/ERTP/src/typeGuards.js

I'm actually surprised I didn't write any comments explaining this at all. I certainly agree it is needed.

Also rest

[erights]

@turadg How much of this issue is addressed by endojs/endo#1715 ?

Note that endojs/endo#1715 is merged into endo. But an endo with that change is not yet released, and therefore not yet available to agoric-sdk.

[turadg]

When I link HEAD of @endo/patterns, it appears to be solved by 1715.

Unfortunately the type when importing M from @agoric/store has gotten worse, in that the whole thing is any. I don't know why but I expect #7949 would fix it

[erights]

Oh sorry! I lost track of #7949. Looking now.

Are you waiting on me for anything else?

[turadg]

No worries! Wasn't waiting on 7949 since it was low prio. If it was high I would have pestered you 😉

[erights]

Good! In any case, LGTMed that one. Please let me know whether it fixes the issue here.