Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the VaultFactory contract upgradable #6791

Closed
turadg opened this issue Jan 14, 2023 · 0 comments · Fixed by #7476
Closed

make the VaultFactory contract upgradable #6791

turadg opened this issue Jan 14, 2023 · 0 comments · Fixed by #7476
Assignees
Labels
enhancement New feature or request Inter-protocol Overarching Inter Protocol vaults_triage DO NOT USE
Milestone

Comments

@turadg
Copy link
Member

turadg commented Jan 14, 2023

What is the Problem Being Solved?

For the next release all contracts with precious state must be upgradable.

Description of the Design

Adopt the vivification methods and iron out kinks.

One will be that outstandingQuote cannot survive upgrade because it's a promise and #3787. Upon upgrade restart the liquidator activity, which is the loop waiting for the quote promise to be resolved. Basically, liquidationInProgress and outstandingQuote need to be made ephemeral.

Security Considerations

Test Plan

There must be an automated test of upgrade, using the new flow framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Inter-protocol Overarching Inter Protocol vaults_triage DO NOT USE
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants