Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vaults chain doesn't support pismo wallet #6993

Closed
arirubinstein opened this issue Feb 13, 2023 · 5 comments
Closed

vaults chain doesn't support pismo wallet #6993

arirubinstein opened this issue Feb 13, 2023 · 5 comments
Assignees
Labels

Comments

@arirubinstein
Copy link
Contributor

Describe the bug

Unable to load a provisioned wallet in wallet.agoric.app due to Error in wallet backend: Cannot read properties of undefined (reading 'find')

To Reproduce

Steps to reproduce the behavior:

  1. wallet.agoric.app with keplr key gov1
  2. configure ollinet
  3. provision wallet
  4. error pops up

Expected behavior

no error, with a list of purses

Screenshot 2023-02-13 at 12 18 29 PM

Screenshot 2023-02-13 at 12 18 24 PM

Screenshot 2023-02-13 at 12 18 07 PM

@samsiegart
Copy link
Contributor

We'll have to upgrade wallet.agoric.app when we upgrade the chain. For now try https://main.wallet-app.pages.dev/wallet/ for a version that's in sync with current master

@dckc
Copy link
Member

dckc commented Feb 14, 2023

o.brands.find(...) is failing because we no longer provide o.brands:

It's a breaking change, but pretty important for performance / scalability.

The dev wallet has been updated to get the info from x/bank and agoricNames.vbankAsset:

Do we want to keep this issue open until the chain is updated and the front end is deployed in production? Or close it as "working as designed"? Or something in between?

@dckc dckc changed the title Can't load wallet on master vaults chain doesn't support pismo wallet Feb 15, 2023
@ivanlei ivanlei added the vaults_triage DO NOT USE label Feb 16, 2023
@ivanlei ivanlei added this to the Vaults EVP milestone Feb 16, 2023
@ivanlei
Copy link
Contributor

ivanlei commented Apr 17, 2023

Expect folks to use the ?wallet=main workaround

@ivanlei ivanlei removed this from the Vaults EVP milestone Apr 18, 2023
@dckc
Copy link
Member

dckc commented Apr 26, 2023

see also Agoric/dapp-psm#58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants