Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VaultManager publish lockedPrice and time for next liquidation #7281

Closed
Chris-Hibbert opened this issue Mar 30, 2023 · 3 comments
Closed

VaultManager publish lockedPrice and time for next liquidation #7281

Chris-Hibbert opened this issue Mar 30, 2023 · 3 comments
Assignees
@Chris-Hibbert
Labels
auction enhancement New feature or request Inter-protocol Overarching Inter Protocol vaults_triage DO NOT USE Vaults VaultFactor (née Treasury)

Comments

@Chris-Hibbert
Copy link
Contributor

Chris-Hibbert commented Mar 30, 2023 •
edited by ivanlei
Loading

What is the Problem Being Solved?

The Vaults UI is expected to show the user the time and price at which liquidation will next take place, but VaultManager (which has the price in its state) is not currently publishing that anywhere.

related - possible dupe - #6947

Description of the Design

Add it to the data published by updateMetrics(). Also add in the scheduled time, which VM knows how to get from the auction.

Security Considerations

None. This is intended to be public info. It could be calculated from info the auction makes available and access to the oracles.

Scaling Considerations

Replaces requests to the on-chain state.

Test Plan

verify that it's being added to metrics, and that it's empty when there's no lockedPrice.
@Chris-Hibbert Chris-Hibbert added enhancement New feature or request Inter-protocol Overarching Inter Protocol Vaults VaultFactor (née Treasury) labels Mar 30, 2023
@Chris-Hibbert Chris-Hibbert self-assigned this Mar 30, 2023
@ivanlei
Copy link
Contributor

ivanlei commented Mar 30, 2023

This should be helpful for #7266

@dckc
Copy link
Member

dckc commented Mar 30, 2023

added to vaults per PM

@dckc dckc mentioned this issue Mar 30, 2023
Closed
@ivanlei ivanlei added the vaults_triage DO NOT USE label Apr 3, 2023
@Chris-Hibbert
Copy link
Contributor Author

This was handled by #7339.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chris-Hibbert Chris-Hibbert

Labels
auction enhancement New feature or request Inter-protocol Overarching Inter Protocol vaults_triage DO NOT USE Vaults VaultFactor (née Treasury)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dckc @ivanlei @Chris-Hibbert