vaultFactory terms: auctioneerPublicFacet or auctioneer instance?

[dckc]

What is the Problem Being Solved?

The vaultFactory's terms include auctioneerPublicFacet; a party who wants to audit/verify the auctioneer is likely to have the instance (for example from agoricNames.instance). This puts the burden on such parties to call E(zoe).getPublicFacet(instance) in order to verify.

Description of the Design

Perhaps the vaultFactory should take the instance and do the call to E(zoe).getPublicFacet(instance)

Security Considerations

Scaling Considerations

Test Plan

[turadg]

@iomekam in the course of #7954 please change it to take the instance instead of the PF.

[dckc]

I still see auctioneerPublicFacet in the terms

agoric-sdk/packages/inter-protocol/src/vaultFactory/vaultDirector.js

Line 88 in e9affc8

* @param {ERef<import('../auction/auctioneer.js').AuctioneerPublicFacet>} auctioneer

Should we close this as not planned, @Chris-Hibbert ?

[turadg]

I still see auctioneerPublicFacet in the terms

That link is to the Director exo. The contract start gets that from the instance in terms:

agoric-sdk/packages/inter-protocol/src/vaultFactory/vaultFactory.js

Lines 106 to 107 in 24f7f32

	const auctioneerPublicFacet = E(zoe).getPublicFacet(auctioneerInstance);

[Chris-Hibbert]

There isn't a way to remove objects from terms on upgrade or restart. As @turadg noted, the Director asks Zoe for the publicFacet, by providing the instance specified in privateArgs. It ignores the old publicFacet, which is still in the terms.

So we made the change proposed in the Design section, though legibility has been lost, since terms is now misleading.

[dckc]

ok. I misread. Thanks for clarifying.