Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test of walletFactory contract upgrade on top of upgrade-11 #8305

Closed
2 tasks done
turadg opened this issue Sep 5, 2023 · 2 comments
Closed
2 tasks done

test of walletFactory contract upgrade on top of upgrade-11 #8305

turadg opened this issue Sep 5, 2023 · 2 comments

Comments

@turadg
Copy link
Member

turadg commented Sep 5, 2023

What is the Problem Being Solved?

#8147 is in master. It was originally planned to out as an upgrade handler, but it will go out as a simple core proposal on top of current Mainnet. That's currently upgrade-11 which is in a release branch.

We need a test of walletFactory contract upgrade happening on top of that upgrade-11 state.

Description of the Design / Test Plan / Upgrade Considerations

  • Cherry-pick the necessary changes to the upgrade-11 / mainnet branch.
  • update docker upgrade tests on mainnet branch to verify a publish bundle of wallet factory built from the local repo, and upgrade through core-eval would work
  • cut a github release that contains the bundle artifact, publish to mainnet
  • pass a core eval governance proposal referencing the bundle hash
  • update master branch docker upgrade tests to publish the artifact pulled from GH release, and upgrade

This issue covers the 1st two steps.

(Thanks @mhofman for help with the plan. --@dckc)

Security / Scaling Considerations

Nothing new since #8156

@dckc
Copy link
Member

dckc commented Sep 6, 2023

backport ran into git merge conflicts

In the dc-sw-backport branch, I tried cherry-picking commits from...

but the latter ran into merge conflicts: the actions.sh changes pre-date moving stuff from upgrade-11 to upgrade-12.

add layer between agoric-11 and agoric-12?

In dc-sw-coreprop / #8308, I'm trying to use some of the nicer js testing stuff in master.

The builders package is not in the container in some approaches.

Another thing I ran into is:

11:57PM ERR UPGRADE "agoric-upgrade-11" NEEDED at height: 595:                              
panic: UPGRADE "agoric-upgrade-11" NEEDED at height: 595:                                                                                                                               
goroutine 38 [running]:                                                                     
github.com/cosmos/cosmos-sdk/x/upgrade.BeginBlocker

@dckc
Copy link
Member

dckc commented Sep 9, 2023

addressed in #8311

@dckc dckc closed this as completed Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants