Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Auction timer repeated actions should catch exceptions or have a way to recover #8307

Closed
Chris-Hibbert opened this issue Sep 5, 2023 · 0 comments · Fixed by #8438
Closed
Assignees
Labels

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

#8296 is an example of a problem caused by a thrown exception inside a timer-scheduled action. When an exception is thrown within a repeated timer action, the timerService deschedules later actions.

Description of the Design

The auction relies on those repeated actions to continue happening for the health of the auction, so it should either catch exceptions, or arrange for recovery.

Security Considerations

The auction failing puts the vaultFactory at risk, which puts IST at risk.

Scaling Considerations

Not an issue.

Test Plan

test thoroughly.

Upgrade Considerations

We need to be able to upgrade the auction and vaultFactory in order to make changes. This depends on #8123, among other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant