Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow return grant of clawback vesting accounts #8570

Closed
JimLarson opened this issue Nov 28, 2023 · 3 comments · Fixed by agoric-labs/cosmos-sdk#342 or #8616
Closed

Allow return grant of clawback vesting accounts #8570

JimLarson opened this issue Nov 28, 2023 · 3 comments · Fixed by agoric-labs/cosmos-sdk#342 or #8616
Assignees
Labels
agoric-cosmos Emerynet test this in emerynet enhancement New feature or request

Comments

@JimLarson
Copy link
Contributor

What is the Problem Being Solved?

We would like the recipient of a clawback vesting grant to be able to return all unvested assets to the funder. This is the same action as the funder-initiated clawback, but initiated by the grantee.

We'd also like grantees of Periodic vesting accounts to be able to return them to the funder some day, but at the moment we do not track the funder.

Description of the Design

  • No ability to return a fraction of the unvested amount - it's all returned.
  • No ability to specify an alternative address, lest it be sent to a grantee-controlled account. It all goes back to the funder address.
  • The self-clawback will be preceded by a withdrawal of all pending staking rewards, and the consequent division into vested and unvested character.

We can leverage the existing clawback mechanism, but because of the slightly different inputs, as well as the future goal of periodic vesting accounts, we'll use a new message type, rather than allowing the recipient to sign the existing clawback message.

Security Considerations

The grantee must not be able to specify an alternative account as the destination of the funds - the funds must only go back to the funder's address.

Scaling Considerations

N/A

Test Plan

Unit testing.

Upgrade Considerations

N/A

@JimLarson JimLarson added enhancement New feature or request agoric-cosmos labels Nov 28, 2023
@JimLarson JimLarson self-assigned this Nov 28, 2023
@JimLarson
Copy link
Contributor Author

@dtribble suggests requiring funder address - a useful statement of intention currently, and useful in the future if we allow multiple grants from different sources.

@dtribble
Copy link
Member

Upon reflection, I think better is that the simple operation is "return everything". Future versions can have arguments when it's well-motivated to select a subset.

@ivanlei ivanlei added the Emerynet test this in emerynet label Dec 4, 2023
@ivanlei ivanlei changed the title Allow self-clawback of clawback vesting accounts Allow return grant of clawback vesting accounts Dec 4, 2023
@JimLarson
Copy link
Contributor Author

Reopening until it's incorporated in agoric-sdk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agoric-cosmos Emerynet test this in emerynet enhancement New feature or request
Projects
None yet
3 participants