Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test that v48-vaultFactory re-subscribes to timer when v5-timer is upgraded #8727

Open
warner opened this issue Jan 9, 2024 · 0 comments
Open
Assignees
Labels
contract-upgrade enhancement New feature or request Inter-protocol Overarching Inter Protocol Vaults VaultFactor (née Treasury)

Comments

@warner
Copy link
Member

warner commented Jan 9, 2024

As part of #8499 (comment) (look for v5-timer-v23-feedistributor-v48-vaultfactory), we're investigating for v48-vaultFactory will react when the upstream v5-timer is upgraded.

v48-vaultFactory has code which talks to the timer service and creates a notifier during helper.start(). The timer service provides durable notifiers, and this subscriber code correctly uses observeNotifier to react to vat-timer being upgraded (and the individual promises being disconnected).

(I suspect this is all working, but if not, it would be a blocker to upgrading v5-timer. Someone who knows what is tested and what is not may be able to trivially close this ticket)

The task is to test this tolerance of upgrading v5-timer, probably through a3p:

  • set up a vault factory, which will establish the timer loop
  • upgrade v5-timer
  • assert that the vault factory has re-subscribed to the timer service
    • perhaps by allowing time to advance and then observing the vault factory reacting to the passage of time correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contract-upgrade enhancement New feature or request Inter-protocol Overarching Inter Protocol Vaults VaultFactor (née Treasury)
Projects
None yet
Development

No branches or pull requests

3 participants