Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In error messages, displaying payments as { getAllegedBrand: [Function: getAllegedBrand] } is not very helpful #989

Closed
DavidBruant opened this issue Apr 23, 2020 · 2 comments
Labels
ERTP package: ERTP

Comments

@DavidBruant
Copy link
Contributor

Derived from a comment in support chat
But also based on my experience

The message that the person received was:

extent has duplicates: { getAllegedBrand: [Function: getAllegedBrand] } and { getAllegedBrand: [Function: getAllegedBrand] }

but as is, the message is unhelpful because it does not contain a description of the extent or the issuer.

I think that having more context in the error message would help making the error more helpful

@DavidBruant DavidBruant added the ERTP package: ERTP label Apr 23, 2020
@katelynsills
Copy link
Contributor

I think we can close this, because it is actually printing the extent. The problem is that in this case, the extent is a payment, so there is no information printed besides the getAllegedBrand method. We wouldn't be able to improve the display-ability of payments in this scenario because we don't want them to be there in the first place.

@erights
Copy link
Member

erights commented Apr 25, 2020

See #804 for our plan that enables presences to carry descriptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ERTP package: ERTP
Projects
None yet
Development

No branches or pull requests

3 participants