From 20db1047027f12ce2bb31630790f7c06ac9e58ab Mon Sep 17 00:00:00 2001 From: Chris Hibbert Date: Wed, 21 Aug 2024 22:40:19 -0700 Subject: [PATCH] refactor: get auction instance from promise space after completion --- .../inter-protocol/src/proposals/upgrade-vaults.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/inter-protocol/src/proposals/upgrade-vaults.js b/packages/inter-protocol/src/proposals/upgrade-vaults.js index 848808d77df..8b031dcccc8 100644 --- a/packages/inter-protocol/src/proposals/upgrade-vaults.js +++ b/packages/inter-protocol/src/proposals/upgrade-vaults.js @@ -29,9 +29,8 @@ export const upgradeVaults = async ( installation: { produce: { VaultFactory: produceVaultInstallation }, }, - instance: { - consume: { auctioneer: auctioneerInstanceP }, - }, + // We want the auction instance after auctionsUpgradeComplete resolves + instance: { consume: consumeInstance }, }, { options }, ) => { @@ -131,9 +130,10 @@ export const upgradeVaults = async ( E.get(reserveKit).creatorFacet, ).makeShortfallReportingInvitation(); + // we want the auctioneer instance after auctionsUpgradeComplete settles const [poserInvitation, auctioneerInstance] = await Promise.all([ E(electorateCreatorFacet).getPoserInvitation(), - auctioneerInstanceP, + E.get(consumeInstance).auctioneer, ]); /** @type {import('../../src/vaultFactory/vaultFactory').VaultFactoryContract['privateArgs']} */ @@ -181,7 +181,7 @@ export const getManifestForUpgradeVaults = async ( installation: { produce: { VaultFactory: true }, }, - instance: { consume: { auctioneer: uV } }, + instance: { consume: true }, }, }, options: { ...vaultUpgradeOptions },