Skip to content
This repository has been archived by the owner on Jun 15, 2024. It is now read-only.

Fail gracefully if user hasn’t set up a wallet bridge properly. #32

Open
katelynsills opened this issue Aug 26, 2021 · 2 comments
Open
Assignees

Comments

@katelynsills
Copy link
Contributor

The deployed dapp does not fail very gracefully when the user hasn’t set up a wallet bridge properly.

There’s a console error in the deployed dapp, emitted from agoric-wallet.html:

found Agoric wallet [object Object]?suggestedDappPetname=cardStore
agoric-wallet.html?suggestedDappPetname=cardStore:24 Uncaught TypeError: Failed to construct 'URL': Invalid URL
    at fromFrame (agoric-wallet.html?suggestedDappPetname=cardStore:24)

The hint appears to be an object where a string is expected. The object is the event.data in a cross-frame MessageEvent, from the local wallet, on https://local.agoric.com/?append=/wallet-bridge.html.

Originally posted by @kriskowal in #31 (comment)

@katelynsills
Copy link
Contributor Author

Hi @michaelfig I assigned this to you because I think it will be solved by the wallet bridge component you were working on, but let me know if that's not the case.

@michaelfig
Copy link
Member

Hi @michaelfig I assigned this to you because I think it will be solved by the wallet bridge component you were working on

It is indeed within the purview of that component. I'll take it from here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants