add e2e testing support for ollinet in CI job #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying dapp-econ-gov with
|
| Latest commit: |
3a3353e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e1622e7a.dapp-econ-gov.pages.dev |
| Branch Preview URL: | https://tl-add-ollinet.dapp-econ-gov.pages.dev |
|
Cloudflare deployment logs are available here |
turadg
requested changes
Aug 23, 2024
tests/e2e/docker-compose.yml
Outdated
| @@ -105,7 +107,7 @@ services: | |||
| profiles: | |||
| - synpress | |||
| container_name: agoric_chain | |||
| image: ghcr.io/agoric/agoric-3-proposals:main | |||
| image: ghcr.io/agoric/agoric-3-proposals:${A3P_BRANCH} | |||
There was a problem hiding this comment.
this is a Docker tag, not branch.
what's publishing an 'ollinet' tag? I don't see one in https://github.com/Agoric/agoric-3-proposals/pkgs/container/agoric-3-proposals
There was a problem hiding this comment.
this docker tag can only be used for local testing and not for ollinet.
for specific a3p tag on ollinet, I will have to make change in instagoric that I can do separately.
removing this change for now.
There was a problem hiding this comment.
@turadg updated the PR.
turadg
approved these changes
Aug 24, 2024
|
Fraz and I made the necessary changes to enable running E2E testing with other testnets besides |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.