Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QST: Functions within Aguaclara package deprecated #233

Open
lainey-reed opened this issue May 1, 2021 · 0 comments
Open

QST: Functions within Aguaclara package deprecated #233

lainey-reed opened this issue May 1, 2021 · 0 comments
Labels
needs triage Issue that has not been reviewed by AC Textbook team member question Further information is requested

Comments

@lainey-reed
Copy link
Contributor

As Ben and I have been putting the textbook code into Colab and running it we have been having some errors in the code which we are not sure how to address. For example, in both Chapter 8 and Chapter 10 the function floc_model.diam_floc_max is called (documentation here: https://aguaclara.github.io/aguaclara/research/floc_model.html?highlight=diam_floc_max#aguaclara.research.floc_model.diam_floc_max)

In the documentation, it says that the underlying theory of the formula has been removed. Should we remove or replace it with another function?

Here are the sections where we found this deprecated function used:
https://aguaclara.github.io/Textbook/Flocculation/Floc_Model_Solution.html#id2
https://aguaclara.github.io/Textbook/Filtration/Filtration_Theory_and_Future_Work.html#floc-size-and-velocity-gradient-calculations

@lainey-reed lainey-reed added question Further information is requested needs triage Issue that has not been reviewed by AC Textbook team member labels May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Issue that has not been reviewed by AC Textbook team member question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant