Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all hard-coded constants from utility files #12

Closed
fletchapin opened this issue Sep 26, 2017 · 1 comment · Fixed by #324 · May be fixed by #311 or #326
Closed

Remove all hard-coded constants from utility files #12

fletchapin opened this issue Sep 26, 2017 · 1 comment · Fixed by #324 · May be fixed by #311 or #326

Comments

@fletchapin
Copy link
Member

We need to go through physchem and other utility files and ensure that any constants used in those files are not hard-coded in but instead reference expert_inputs or materials_database. For example RATIO_VC_ORIFICE is defined as 0.62 in physchem but instead it should be defined as exp.RATIO_VC_ORIFICE to maintain dependency
@fletchapin fletchapin changed the title Removing all hard-coded constants from utility files Remove all hard-coded constants from utility files Sep 26, 2017
@eak24
Copy link
Contributor

eak24 commented Sep 26, 2017

This is a fine thing to do. You can automate the process by running pylint... 'linting' code refers to running an automated linter through it that can identify common problems in style

@vaishnavi-vinodh vaishnavi-vinodh mentioned this issue Apr 20, 2021
Closed
This was referenced May 8, 2021
Closed
Open
Closed
@fletchapin fletchapin mentioned this issue Feb 8, 2023
Merged
@monroews monroews mentioned this issue Aug 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@eak24 @fletchapin