Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #326

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update README.md #326

wants to merge 4 commits into from

Conversation

monroews
Copy link
Contributor

fix link to developer guide

Pull request recommendations:

  • Name your pull request {your development type}: {short description}. Ex: Feature: flocculator validation
  • Link to any relevant issue in the PR description. Ex: Resolves Remove all hard-coded constants from utility files #12, adds flocculator validation
  • Provide context of changes.
  • Provide relevant tests for your feature or bug fix.
  • Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

@fletchapin fletchapin self-requested a review August 19, 2024 23:41
@fletchapin
Copy link
Member

Hi @monroews I realized there was an issue in the Codecov GitHub Action that was leading the tests to fail. After updating the token the tests should now all pass so I approved the PR and we should be able to merge it!

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.54%. Comparing base (4db315b) to head (06f6b1f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
- Coverage   89.56%   89.54%   -0.02%     
==========================================
  Files          29       29              
  Lines        3047     3042       -5     
==========================================
- Hits         2729     2724       -5     
  Misses        318      318              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all hard-coded constants from utility files
2 participants