Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish releases to maven #64

Open
rursprung opened this issue Jun 16, 2022 · 13 comments
Open

publish releases to maven #64

rursprung opened this issue Jun 16, 2022 · 13 comments

Comments

@rursprung
Copy link
Contributor

rursprung commented Jun 16, 2022

it'd be great if you could publish your releases to maven (we use it to manage our dependencies, incl. opensearch & opensearch plugins).

you can use the opensearch.pluginzip gradle plugin for this: see the opensearch plugins documentation on this and opensearch-project/opensearch-build#1916.

@lukas-vlcek
Copy link
Collaborator

Hi @rursprung

If I read it correctly you would like to have the apply plugin: 'opensearch.pluginzip' be added to build.gradle so that you can call the new custom publish task publishPluginZipPublicationToZipStagingRepositoryand to have the plugin ZIP be pushed into mvn repo of your choice?

Do I get correctly?

@rursprung
Copy link
Contributor Author

not quite: the idea would be that the publish would happen as part of your normal release, so that it's on maven central (or any other public maven repo). then it can be pulled in by everyone who needs it (or manually downloaded; same as through the GH releases page - that way it can act as a mirror as well).
but yes, this happens - partially - through that plugin. i haven't used that plugin, so i'm not 100% sure how much of the publishing it automates away, but it's being added to all plugins under the opensearch organisation (some have already done it, others still have an open ticket for it).

@lukas-vlcek
Copy link
Collaborator

I was looking at this and I ran into some issues, see opensearch-project/OpenSearch#3649
It seems the bug will be fixed soon (kudos to @reta) but we will be able to benefit from it only after new OpenSearch release with the fix is out.

I will keep the ticket open but for the time being the status is:
"We are waiting for the (OpenSearch) upstream and new release."

@lukas-vlcek lukas-vlcek added the waiting for upstream release Waiting for a new OpenSearch release with the fix included label Jun 23, 2022
@reta
Copy link
Contributor

reta commented Jun 23, 2022

@lukas-vlcek you could remove url & scm section from pluginzip publishing goal for now - those are picked up from the build anyway (the scm protocol is slightly different but not a big deal right now).

@lukas-vlcek
Copy link
Collaborator

I think this is also related: opensearch-project/OpenSearch#3692

@lukas-vlcek
Copy link
Collaborator

@rursprung based on the discussion in opensearch-project/OpenSearch#3692 I will "friendly" close this ticket as won't fix. Once OpenSearch enables custom groupId values in POM we can revisit it.

@lukas-vlcek lukas-vlcek added wontfix This will not be worked on and removed waiting for upstream release Waiting for a new OpenSearch release with the fix included labels Jun 27, 2022
@lukas-vlcek lukas-vlcek mentioned this issue Jun 29, 2022
5 tasks
@lukas-vlcek
Copy link
Collaborator

lukas-vlcek commented Aug 29, 2022

Status update:

@lukas-vlcek
Copy link
Collaborator

Update:

Once the OpenSearch release 2.4 is out we can re-open this ticket.

@rursprung
Copy link
Contributor Author

@lukas-vlcek 2.4 is out, i guess this can be re-opened? (not something that i can do) 🙂
thanks a lot for all your heavy work on the publishing mechanism!

@lukas-vlcek lukas-vlcek reopened this Dec 1, 2022
@lukas-vlcek
Copy link
Collaborator

Sure, we can now continue.

I think one of the changes I would like to do first is changing the "package" name of internal classes to something that will match the groupId in the maven repo. Perhaps to something like io.aiven.plugin or similar. Definitely not org.opensearch because that is already taken by the core OpenSearch plugins.

(Although it is possible to override the groupId in gradle publication task I would rather use package name that is really used by the plugin in the code, hence the change ^^)

@lukas-vlcek lukas-vlcek removed the wontfix This will not be worked on label Dec 2, 2022
@rursprung
Copy link
Contributor Author

@lukas-vlcek: do you think it'd now be possible to pick this up? the packages are still named org.opensearch.[..], not sure if you've already picked a new name?
thanks!

@dancristiancecoi
Copy link

Hello, any plans for this to be worked on in the near future?
Btw, thanks a lot for releasing and maintaining this project!

@lukas-vlcek
Copy link
Collaborator

lukas-vlcek commented Aug 4, 2023

Right, I will start working on that too.

It will need to become part of the release process. The following are some articles to start with:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants