Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve primitiveSize #137

Open
PalumboN opened this issue Apr 2, 2024 · 0 comments
Open

Improve primitiveSize #137

PalumboN opened this issue Apr 2, 2024 · 0 comments
Labels
bug Something isn't working primitive Compiling primitives

Comments

@PalumboN
Copy link
Contributor

PalumboN commented Apr 2, 2024

Now it is compiled always as 0 args. But the interpreter works with 1 arg also (see Context >> objectSize: anObject).

The primitive should have <numberOfArguments: #(0 1)> to support both cases, or at least <numberOfArguments: #(0)> to check the method argument count.

But now we cannot do that because tests are failing (probably due a bug during the optimisation passes).
@PalumboN PalumboN added bug Something isn't working primitive Compiling primitives labels Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working primitive Compiling primitives
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PalumboN