You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've had a look at the code and cannot see any form of rate limiting for downloading the data from the AoC site, this could result in the undesirable multiple requests per second that Eric tries to avoid.
It is possible that I've overlooked something, but if not may I suggest that you put an appropriate sleep in to pull back a bit. This shouldn't be a problem for people using init/py to pick up 'todays' data and those picking up the historical data isn't going to be too worried about speed as they won't be racing for a placing.
The text was updated successfully, but these errors were encountered:
Hello, thank you for submitting an issue.
While I do agree with you, I do not plan on working on this repo anytime soon.
I did this repo for fun and friends while I while still learning Python, and the code quality is rather low and all over the place. I also believe this repo is not popular enough to justify a change.
I've had a look at the code and cannot see any form of rate limiting for downloading the data from the AoC site, this could result in the undesirable multiple requests per second that Eric tries to avoid.
It is possible that I've overlooked something, but if not may I suggest that you put an appropriate
sleep
in to pull back a bit. This shouldn't be a problem for people usinginit/py
to pick up 'todays' data and those picking up the historical data isn't going to be too worried about speed as they won't be racing for a placing.The text was updated successfully, but these errors were encountered: