Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed of accessing AoC #1

Open
GeoffRiley opened this issue Dec 1, 2021 · 1 comment
Open

Speed of accessing AoC #1

GeoffRiley opened this issue Dec 1, 2021 · 1 comment
Labels
wontfix This will not be worked on

Comments

@GeoffRiley
Copy link

I've had a look at the code and cannot see any form of rate limiting for downloading the data from the AoC site, this could result in the undesirable multiple requests per second that Eric tries to avoid.

It is possible that I've overlooked something, but if not may I suggest that you put an appropriate sleep in to pull back a bit. This shouldn't be a problem for people using init/py to pick up 'todays' data and those picking up the historical data isn't going to be too worried about speed as they won't be racing for a placing.

@AlexeSimon
Copy link
Owner

Hello, thank you for submitting an issue.
While I do agree with you, I do not plan on working on this repo anytime soon.

I did this repo for fun and friends while I while still learning Python, and the code quality is rather low and all over the place. I also believe this repo is not popular enough to justify a change.

You may look into https://github.com/Tisawesomeness/AdventOfCodeTemplate , which seems already better, and see if it has the same issue.

@AlexeSimon AlexeSimon added the wontfix This will not be worked on label Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants