Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Fin(Dom)Functions to use Columns #706

Open
epatters opened this issue Nov 7, 2022 · 1 comment
Open

Refactor Fin(Dom)Functions to use Columns #706

epatters opened this issue Nov 7, 2022 · 1 comment
Assignees

Comments

@epatters
Copy link
Member

epatters commented Nov 7, 2022

Since #681, we have two parallel implementations of functions with indexing: the one in FinSets and the columns comprising acsets. We should refactor a Fin(Dom)Function to be a column together with domain and codomains (at least in the case where the function is given by explicit data, as opposed to a callable).

As part of this, we should fix #687.

@kris-brown
Copy link
Contributor

Another issue we've seen in the tests is that the return type of preimage seems to always be a vector, even though there is a type parameter for what type is used internally for storing preimages (e.g. SortedSet or Set). Is this intended or a bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants