You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since #681, we have two parallel implementations of functions with indexing: the one in FinSets and the columns comprising acsets. We should refactor a Fin(Dom)Function to be a column together with domain and codomains (at least in the case where the function is given by explicit data, as opposed to a callable).
Another issue we've seen in the tests is that the return type of preimage seems to always be a vector, even though there is a type parameter for what type is used internally for storing preimages (e.g. SortedSet or Set). Is this intended or a bug?
Since #681, we have two parallel implementations of functions with indexing: the one in
FinSets
and the columns comprising acsets. We should refactor aFin(Dom)Function
to be a column together with domain and codomains (at least in the case where the function is given by explicit data, as opposed to a callable).As part of this, we should fix #687.
The text was updated successfully, but these errors were encountered: