Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FinSets from FinSetImpls, etc #889

Open
KevinDCarlson opened this issue Feb 20, 2024 · 0 comments
Open

Refactor FinSets from FinSetImpls, etc #889

KevinDCarlson opened this issue Feb 20, 2024 · 0 comments
Labels

Comments

@KevinDCarlson
Copy link
Contributor

"It's something unpredictable//But in the end it's right..."
--Billie Joe Armstrong

It's too hard to have FinDomFunction and FinSet be abstract types. Make them and others concrete types according to the general design

abstract type FinSetImpl
struct FinSet
  theSet::FinSetImpl
end

Then we refactor so that the majority of functions involving sets and functions act on the pseudo-concrete wrapper types, which means you can't access details of the implementation, but on the other hand you can map over something without constantly freaking out over whether it's a collection of FinDomFunctionDicts or FinDomFunctionVectors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants