Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cu_wedge exports #81

Closed
GeorgeR227 opened this issue May 14, 2024 · 6 comments
Closed

Remove cu_wedge exports #81

GeorgeR227 opened this issue May 14, 2024 · 6 comments
Assignees

Comments

@GeorgeR227
Copy link
Contributor

export dec_boundary, dec_differential, dec_dual_derivative, dec_hodge_star, dec_inv_hodge_star, dec_wedge_product, dec_c_wedge_product, dec_p_wedge_product, dec_c_wedge_product!,
dec_wedge_product_pd, dec_wedge_product_dp, ,
interior_product_dd, ℒ_dd,
dec_wedge_product_dd,
Δᵈ,
dec_cu_c_wedge_product!, dec_cu_c_wedge_product, dec_cu_p_wedge_product, dec_cu_wedge_product

The exports on line 17 are no longer needed since the calling of CUDA wedge products has been changed to dispatch from regular dec wedge products.

@lukem12345
Copy link
Member

In the PR that closes this issue, a doc string for the FastDEC module should be added. This will help clarify which functions are exported and why.

@lukem12345
Copy link
Member

@GeorgeR227 Does this issue obstruct the merging of AlgebraicJulia/Decapodes.jl#225 ?

@GeorgeR227
Copy link
Contributor Author

I'm running the tests now but I don't expect any problems.

@lukem12345
Copy link
Member

@GeorgeR227 Do you have any updates on those CUDA tests?

@GeorgeR227
Copy link
Contributor Author

All tests passed.

@lukem12345
Copy link
Member

OK, make a PR and request review and we can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants