Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gray Scott model #114

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Add Gray Scott model #114

merged 3 commits into from
Jul 21, 2023

Conversation

lukem12345
Copy link
Member

Add an example of the Gray Scott chemical reaction model as a Decapode.

I will leave this as a draft until I study this model some more and verify that the phenomena that we observe are correct.

This should also be managed using the DrWatson.jl system along with the current Brusselator example.

gray_scott
gray_scott_sphere_compressed

@lukem12345 lukem12345 self-assigned this Apr 7, 2023
@jpfairbanks
Copy link
Member

These look pretty good!

@lukem12345
Copy link
Member Author

lukem12345 commented Jul 21, 2023

After amending the typo pointed out by @djinnome , the Gray-Scott model with the given initial conditions exhibits the following dynamics on the plane. The sphere gif is too large to upload, but behaves similarly to above.

gray_scott_here

@lukem12345 lukem12345 marked this pull request as ready for review July 21, 2023 19:13
@lukem12345
Copy link
Member Author

There's a merge conflict that I'll look at later. The current gray_scott.jl script is updated to the most recent version of Decapodes, and so can be downloaded and run there

@jpfairbanks
Copy link
Member

I think that was a false positive on the merge conflict. I just did a git merge locally and it reported no conflicts.

@lukem12345
Copy link
Member Author

Great, feel free to merge in Gray-Scott pending your review.

@jpfairbanks
Copy link
Member

Approved, just waiting for tests

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ca86084) 88.40% compared to head (f584fdd) 88.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #114   +/-   ##
=======================================
  Coverage   88.40%   88.40%           
=======================================
  Files           9        9           
  Lines        1009     1009           
=======================================
  Hits          892      892           
  Misses        117      117           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lukem12345 lukem12345 merged commit de5e4e1 into main Jul 21, 2023
9 checks passed
@epatters epatters deleted the llm/gray_scott branch July 21, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants