Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cm/canon oncology #223

Merged
merged 7 commits into from
May 14, 2024
Merged

Cm/canon oncology #223

merged 7 commits into from
May 14, 2024

Conversation

quffaro
Copy link
Member

@quffaro quffaro commented Apr 10, 2024

Added Logistic and Gompertz growth models to Canon.Oncology. coded by @lukem12345 @GeorgeR227 and researched by myself

Copy link
Member

@jpfairbanks jpfairbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would really help convince oncology modelers that Decapodes has something to offer them if you could

  • pull the logistic and gompertz laws out into their own Decapodes
  • do "GrowthDiffusion" as a model that expects a growth law,
  • build these two models with an ocompose,
  • make a docs page running both models and comparing them

The separation of concerns between the local growth law and the diffusion law is really nice because people say "we ran X physics with Y growth term" all the time in MathOnco. This formulation actually embeds that 2D structure into the code.

@quffaro
Copy link
Member Author

quffaro commented Apr 10, 2024

I agree. Along the same...vein, I've discussed with @lukem12345 last week that a model for angiogenesis in tumor growth appear to be compositions of two growth models, and that we could be a neat compositional example.

I'll get started on your suggestion.

@lukem12345
Copy link
Member

@quffaro I know that you will be further investigating applications, but is this PR ready to merge?

@quffaro quffaro merged commit 05376d9 into main May 14, 2024
7 of 8 checks passed
@lukem12345
Copy link
Member

@quffaro In the future please squash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants