Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement for GATExpr #77

Merged
merged 10 commits into from
Aug 22, 2023
Merged

Replacement for GATExpr #77

merged 10 commits into from
Aug 22, 2023

Conversation

olynch
Copy link
Member

@olynch olynch commented Jun 30, 2023

In order to replace the old GAT system, we need a replacement for the GATExpr system, and the FreeCategory stuff that went along with it.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 78.48% and project coverage change: -4.45% ⚠️

Comparison is base (b8dd6fa) 70.00% compared to head (83acf1c) 65.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   70.00%   65.55%   -4.45%     
==========================================
  Files          40       41       +1     
  Lines        1327     1385      +58     
==========================================
- Hits          929      908      -21     
- Misses        398      477      +79     
Files Changed Coverage Δ
src/models/MethodInstance.jl 1.88% <0.00%> (-0.04%) ⬇️
src/models/module.jl 100.00% <ø> (ø)
src/stdlib/models/SimpleLenses.jl 8.33% <ø> (-71.67%) ⬇️
src/stdlib/models/SliceCategories.jl 60.00% <0.00%> (ø)
src/syntax/Pushouts.jl 96.29% <ø> (ø)
src/syntax/TheoryMaps.jl 88.46% <ø> (ø)
src/util/MetaUtils.jl 1.38% <0.00%> (-0.07%) ⬇️
src/syntax/Theories.jl 86.11% <91.30%> (+1.22%) ⬆️
src/dsl/TheoryMacros.jl 89.83% <100.00%> (-0.12%) ⬇️
src/models/SymbolicModels.jl 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olynch
Copy link
Member Author

olynch commented Aug 22, 2023

Only the basic functionality is implemented, but I'm going to merge this because I want to clean things up in other branches.

@olynch olynch merged commit 5673714 into main Aug 22, 2023
8 of 9 checks passed
@kris-brown kris-brown deleted the typed-exprs branch September 21, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant