Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install fails in restricted network environment (proxied npm registry) #861

Closed
lukateake opened this issue Nov 28, 2016 · 6 comments
Closed

Comments

@lukateake
Copy link

@AllenFang, by adding a dependency to an unreleased version, our install fails in a network restricted environment.

Please see this NPM post on how to deal with this issue:
http://blog.npmjs.org/post/145724408060/dealing-with-problematic-dependencies-in-a

It’s usually a good idea to open an issue on the project with the Git dependency, politely asking the maintainers to replace the Git dependency, if possible. Generally, we discourage using Git dependencies in package.json, and it’s typically only used temporarily while a maintainer waits for an upstream fix to be applied and published.

@AllenFang
Copy link
Owner

@lukateake, it’s typically only used temporarily while a maintainer waits for an upstream fix to be applied and published. that's the reason that I use git dependency. check #838

Anyway, I'll check this out. Thanks.

@tplummerfni
Copy link

tplummerfni commented Dec 12, 2016

Second this. We're running through a local Private NPM Registry. Our build server does not have access to github. I was under the impression that a Private Registry would cache all modules, but what appears to be happening is the client is ignoring the cached version and going for github. Not necessarily an issue with this project, but giving it a version instead of a github reference would solve the issue.

@AllenFang
Copy link
Owner

Hi all, sorry for lately fixing.... Released on v2.7.0, check this out, I've packaged the react-toastr as a scope module. Let me know if problem still remain. thanks

@lukateake
Copy link
Author

@AllenFang, this is still a problem for us even with the scope packaging, unfortunately.

Would you be amenable to removing the react-toastr dependency all together? I thought I saw somewhere that you're looking for PR help to that effect.

I'm happy to take a cut at it but could use a little guidance on how you'd prefer me to proceed.

@AllenFang
Copy link
Owner

For this issue, maybe you can check #1152

And for react-toastr, That's my thought, It's a pretty bad idea to depend with react-toastr, I should make the display message much customizable and use a more simple way to show the message(Like window.confirm or native bootstrap modal), but I didn't. And react-toastr was be depended for a long time, if I remove it now, I think there're a lots of people to concern. But actually I really really want to remove it :)

Anyway, I've planned to create react-bootstrap-table2 to fix some critical bug(unalign issues and related issues) and it'll be a big change because the DOM and table structure will be different. So in react-bootstrap-table2, I also want to remove react-toastr and maybe support the fixed column, column resize etc. Anyway, It still on plan, but for me, I may not consider to remove react-toastr in this project or event in next major version, it's a big impact for all user

@AllenFang
Copy link
Owner

please check #1216, if you have any concern or question, let me know in #1216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants