-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend the select
operation to allow more fine grained sweep selection
#2012
Comments
All operations will accept an array of select statements. Operations which accept a range will drop that argument. tp will warn when range is set in the select statement.
Approaches not choosen2. Combined array
|
This comment was marked as outdated.
This comment was marked as outdated.
@t-b I'd also like to add an option to select all baseline or all pulse epochs, for example. We could also give the user a chance to apply some QC. e.g., check for spikes in baseline data? |
And it would be nice if we could recursively do selections:
This helps in disecting a bunch of sweeps (an RAC?) into two selections, one for each SCI for example. |
Thought regarding select itself can not determine if ranges are good as this is depending on sweep / channelNumber / channelType. Thus, it makes no sense to think of any AND way to combine ranges when multiple are specified. e.g. Currently the implementation just gathers all ranges specified. As Regarding other entries appearing multiple times in |
behavior for select:
|
|
The select operation 1 has the following signature:
now we would like to add more control over sweep selection. Not only should it be able to select via displayed and clampmode but also via stimulus set and if it passed or not.
Sweep passing state is a LBN entry, see
PSQ_FMT_LBN_SWEEP_PASS
2 as input forCreateAnaFuncLBNKey
.Not all analysis functions have that entry, only DA, SP, RA, CR, PB, SE, VM, AR so from the complete list
and that means PSQ_Rheobase needs to be covered differently (see AD_FillWaves line 344, but note #2017).
Idea:
where all
selectXXX
operations would beand
-ed.As users would also like to select multiple options OR'ed (e.g. passing sweeps from stimset A and failing sweeps from stimset B) we propose to allow an array of
select()
for all operations which accept a select statement (tp
,data
,psxKernel
,psxStats
,epochs
,labnotebook
).The text was updated successfully, but these errors were encountered: