Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ascent singleton reckoning #1357

Open
cyrush opened this issue Aug 13, 2024 · 1 comment
Open

ascent singleton reckoning #1357

cyrush opened this issue Aug 13, 2024 · 1 comment

Comments

@cyrush
Copy link
Member

cyrush commented Aug 13, 2024

advanced cases of ascent require multiple instances of ascent, but there are a few singletons we rely on, for example:

  • expression caching and execution
  • flow mpi comm

This is fine we we are using multi process, but won't work with threaded use cases

As part of #1355, we should also resolve this.

@cyrush
Copy link
Member Author

cyrush commented Aug 13, 2024

Refactor any use of:

flow::Workspace::default_mpi_comm();

To obtain an mpi comm id from the workspace registry instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant