Use at least one BackBuffer in D3D8DeviceEx #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WinterSnowfall
force-pushed
the
d8vk-redfaction
branch
from
d25a5e4
to
2b61982
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets Red Faction going up to the game menu and mirrors what D3D9 does. I think I'm doing the right thing here, but please treat all my PRs as unexploded ordnance.
This was discovered while investigating a crash in IDirect3DDevice8::GetBackBuffer. Red Faction will create a IDirect3DDevice8 with BackBufferCount = 0, then call GetBackBuffer for iBackBuffer = 0, which would try to assign it on top of an out of bounds vector index.
P.S.: Apparently also fixes #79 🎉