Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to integrate through JS + divs (Google Ad Manager) #46

Open
Ivshti opened this issue Jan 21, 2020 · 2 comments
Open

option to integrate through JS + divs (Google Ad Manager) #46

Ivshti opened this issue Jan 21, 2020 · 2 comments
Assignees

Comments

@Ivshti
Copy link
Member

Ivshti commented Jan 21, 2020

Consider a new integration option, where you insert a JS in your page and also insert <div>s for every placement. This is actually how most ad networks work.

Pros:

  • no <iframe>, which also makes it friendlier to Google Ad Manager
  • we can vaguely control the placement we do that via 79ad0be
  • we can detect whether it's in the viewport

Cons:

  • slightly more difficult integration
  • has to init an iframe to read from the AdEx Profile, but then every domain can read from the AdEx profile... this might not be so bad, since every publisher can do you a service by accessing this info; alternatively the iframe can encrypt it for the market and we can share that

related to #35

@Ivshti Ivshti added this to the v1.1 milestone Jan 21, 2020
@Ivshti Ivshti self-assigned this Jan 21, 2020
@Ivshti Ivshti changed the title option to integrate through JS + divs option to integrate through JS + divs (Google Ad Manager) Mar 16, 2020
@Ivshti
Copy link
Member Author

Ivshti commented Mar 30, 2020

may assign this to @rori4 if I don't get to it

@Ivshti Ivshti removed this from the v1.1 milestone May 31, 2020
@Ivshti Ivshti assigned rori4 and unassigned Ivshti Nov 26, 2020
@rori4
Copy link
Contributor

rori4 commented Jan 22, 2021

Is the latest merge deployed? I will need it in order to make a sample integration with google ad manager and describe on how it can be done to Nadia.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants