Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When vstrt.dll fails to preload stuff the plugin crashes #9

Closed
YomikoR opened this issue Nov 15, 2022 · 2 comments
Closed

When vstrt.dll fails to preload stuff the plugin crashes #9

YomikoR opened this issue Nov 15, 2022 · 2 comments
Assignees

Comments

@YomikoR
Copy link

YomikoR commented Nov 15, 2022

Ideally I should be able to see these errors in a previewer

@AkarinVS
Copy link
Member

i've pushed a fix.
please see if this build https://github.com/AmusementClub/vs-mlrt/actions/runs/3477298918 fixes the issue for you.

now if preload fails, the whole plugin will skip registering the trt plugin namespace, so previewer should be able to report a nicer error (No attribute with the name trt exists. Did you mistype a plugin namespace?). And when the user runs the failing script in terminal, it should print out exactly which DLL fails to preload.

@AkarinVS AkarinVS self-assigned this Nov 16, 2022
@YomikoR
Copy link
Author

YomikoR commented Nov 16, 2022

Thanks so much

@YomikoR YomikoR closed this as completed Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants