Polyline Crash on Undefined Globe Fix #5413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good @WilliamKHo, thanks! Can you update CHANGES.md and add a unit test? The user who reported the issue posted a link to a sandcastle example that reproduces the crash in this post: https://groups.google.com/forum/#!msg/cesium-dev/UboMKwwn8Xk/noMUrTS7CQAJ |
|
Hey please look over this? |
|
Looks good! You have a merge conflict though, so merge in master and we'll get this in |
|
Ok should be good now! |
|
👍 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #5146. Ellipsoid assignment moved to
updateand check added for globe. Without the globe the polyline is drawn as a straight line segment. Hopefully this is appropriate behavior?