Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative path for Bing metadata #6597

Merged
merged 1 commit into from
May 17, 2018
Merged

Use relative path for Bing metadata #6597

merged 1 commit into from
May 17, 2018

Conversation

slozier
Copy link
Contributor

@slozier slozier commented May 17, 2018

With the leading slash the url is always rooted. For example if I give the url http://foo.bar/foo/bar/ it will query http://foo.bar/REST/v1/Imagery/Metadata/... instead of the expected http://foo.bar/foo/bar/REST/v1/Imagery/Metadata/....

@cesium-concierge
Copy link

Signed CLA is on file.

@slozier, thanks for the pull request! Maintainers, we have a signed CLA from @slozier, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@shunter
Copy link
Contributor

shunter commented May 17, 2018

Looks good to me. I added some tests, so I'll merge via command line.

I also made a change to add a slash to the provided URL. http://foo.bar/foo/bar/ and http://foo.bar/foo/bar should be treated the same.

Thanks for the fix. I assume you have a private Bing Maps server? (what used to be called "Virtual Earth Server")

@shunter shunter merged commit b2e7fd4 into CesiumGS:master May 17, 2018
shunter added a commit that referenced this pull request May 17, 2018
@pjcozzi
Copy link
Contributor

pjcozzi commented May 19, 2018

Thanks again @slozier!

@shunter if this warrants an update to CHANGES.md in master, can you please make the change.

shunter added a commit that referenced this pull request May 21, 2018
@slozier slozier deleted the bing branch May 23, 2018 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants