Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Spotify Playlists bug #402

Closed
Klairm opened this issue May 9, 2021 · 14 comments · Fixed by #405
Closed

[BUG] Spotify Playlists bug #402

Klairm opened this issue May 9, 2021 · 14 comments · Fixed by #405
Labels
bug Something isn't working develop:resolved

Comments

@Klairm
Copy link
Contributor

Klairm commented May 9, 2021

Describe the bug
One problem with spotify playlists is , that when you parse a playlist, it won't play the songs of the playlist, somehow it will play other random songs, this doesn't happens if you parse the exactly song.

To Reproduce
Steps to reproduce the behavior:

  1. Parse a spotify playlist to the bot using discord-player
  2. Wait almost 30seg to load up the playlist
  3. It will start playing other random songs instead of the playlists songs

Expected behavior
It should play the correct songs from the playlist parsed.

Screenshots
https://i.imgur.com/839boz3.png

Please complete the following information:

  • Node Version: [8.10.0]
  • Discord Player Version: [12.5.1]
  • Discord.js Version: [4.0.5]
@Klairm Klairm added the bug Something isn't working label May 9, 2021
@JonMoriSenpai
Copy link

JonMoriSenpai commented May 9, 2021

Describe the bug
One problem with spotify playlists is , that when you parse a playlist, it won't play the songs of the playlist, somehow it will play other random songs, this doesn't happens if you parse the exactly song.

To Reproduce
Steps to reproduce the behavior:

  1. Parse a spotify playlist to the bot using discord-player
  2. Wait almost 30seg to load up the playlist
  3. It will start playing other random songs instead of the playlists songs

Expected behavior
It should play the correct songs from the playlist parsed.

Screenshots
https://i.imgur.com/839boz3.png

Please complete the following information:

  • Node Version: [8.10.0]
  • Discord Player Version: [12.5.1]
  • Discord.js Version: [4.0.5]

I am also facing quite a few days ! Btw it is occurring with albums and playlist , Luckily We get any correct Song Track ! And

I am Using :-

  • Node Version: [15.14.0]
  • Discord Player Version: [4.0.6]
  • Discord.js Version: [12.5.3]

@twlite
Copy link
Collaborator

twlite commented May 9, 2021

We can't really do anything about this because:

  1. Spotify does not allow us to download their content
  2. We are parsing basic details and searching each of your songs in youtube
  3. Since spotify and youtube are different thing, search result would not be the same at all

@Klairm
Copy link
Contributor Author

Klairm commented May 9, 2021

@twlite
Copy link
Collaborator

twlite commented May 9, 2021

What about in integrating this https://github.com/lavalibs/lavalink.js#readme + https://www.npmjs.com/package/lavasfy

I guess no, current method is kind of accurate too.

image

@twlite
Copy link
Collaborator

twlite commented May 9, 2021

This usually happens when youtube does not have accurate results. Most of the time, it should work tho because youtube does have a lot of songs. We can't really expect this to be 100% accurate because it starts from spotify but ends at youtube which are completely different platforms.

@Klairm
Copy link
Contributor Author

Klairm commented May 9, 2021

Yes but it's kinda weird, because if I try to play the same songs individually it will work perfectly, so it's really getting the song from youtube, but somehow when it's from playlist sometimes doesn't get it correctly, like here:
https://i.imgur.com/7H93WMQ.png

I guess that when accesing the data from spotify is worst than getting the strings of the search

@JonMoriSenpai
Copy link

JonMoriSenpai commented May 10, 2021

What about in integrating this https://github.com/lavalibs/lavalink.js#readme + https://www.npmjs.com/package/lavasfy

I guess no, current method is kind of accurate too.

image

you are right but custom playlists or some other random Playlists present globally made by some other people in spotify doesn't work correctly ! kinda feels like it does searches for artist/author for those Custom Playlists

@twlite
Copy link
Collaborator

twlite commented May 10, 2021

What about in integrating this https://github.com/lavalibs/lavalink.js#readme + https://www.npmjs.com/package/lavasfy

I guess no, current method is kind of accurate too.
image

you are right but custom playlists or some other random Playlists present globally made by some other people in spotify doesn't work correctly ! kinda feels like it does searches for artist/author for those Custom Playlists

I've added an option to disable artist search for spotify. Ex: by default it would search artist - track and when it is disabled, it goes with the another option i.e. track

@JonMoriSenpai
Copy link

What about in integrating this https://github.com/lavalibs/lavalink.js#readme + https://www.npmjs.com/package/lavasfy

I guess no, current method is kind of accurate too.
image

you are right but custom playlists or some other random Playlists present globally made by some other people in spotify doesn't work correctly ! kinda feels like it does searches for artist/author for those Custom Playlists

I've added an option to disable artist search for spotify. Ex: by default it would search artist - track and when it is disabled, it goes with the another option i.e. track

okk thats nice and helpful ,how to disable it ? I can't find it anywhere !

@twlite
Copy link
Collaborator

twlite commented May 10, 2021

@SidisLiveYT I don't think that would help much but searching track title would kind of increase accuracy I guess?

and to use this feature, you need the develop version of discord-player

@JonMoriSenpai
Copy link

@SidisLiveYT I don't think that would help much but searching track title would kind of increase accuracy I guess?

and to use this feature, you need the develop version of discord-player

yeah seeing current issue , searching title will help it alot ! and how to use the develop ??

@twlite
Copy link
Collaborator

twlite commented May 10, 2021

develop version should be merged into master in few days. It will be available as soon as it gets merged

@JonMoriSenpai
Copy link

develop version should be merged into master in few days. It will be available as soon as it gets merged

Okk Thanks ! I will be waiting for it !!

@twlite
Copy link
Collaborator

twlite commented May 10, 2021

ok this issue seems to be fixed by 5386bbc and de40d18

However, can't say it is 100% accurate

@twlite twlite mentioned this issue May 10, 2021
3 tasks
@twlite twlite linked a pull request May 10, 2021 that will close this issue
3 tasks
@twlite twlite mentioned this issue May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working develop:resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants