-
Notifications
You must be signed in to change notification settings - Fork 17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test/test_bootstrap.py requires update; otherwise this looks good to me.
Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm following issue is fixed with this PR: wasm_serialization_error: Serialization Error Processing WASM env.set_wasm_parameters_packed unresolveable
I still see this issue when running test_boostrap.py
:
failed transaction: e7c52027ae987c77daf60092c3b17709b9e862321080ede70266f134dcdd6e28 <unknown> bytes <unknown> us
error 2022-12-30T11:38:13.301 cleos main.cpp:700 print_result ] soft_except->to_detail_string(): 3100006 subjective_block_production_exception: Subjective exception thrown during block production
protocol feature with digest '825ee6288fb1373eab1b5187ec2f04f6eacb39cb3a97f356a07c91622dd61d16' is unrecognized
{"digest":"825ee6288fb1373eab1b5187ec2f04f6eacb39cb3a97f356a07c91622dd61d16"}
nodeos controller.cpp:2703 preactivate_feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, though I'd prefer to see tests updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fix of the bug #80