Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test to verify replay of blocks with bad QC data #727

Closed
arhag opened this issue Sep 9, 2024 · 0 comments · Fixed by #759 or #766
Closed

Add unit test to verify replay of blocks with bad QC data #727

arhag opened this issue Sep 9, 2024 · 0 comments · Fixed by #759 or #766
Assignees
Milestone

Comments

@arhag
Copy link
Member

arhag commented Sep 9, 2024

Adds tests to check that the changes of #693 are implemented correctly.

Bad QC data includes:

  • Invalid QC claim (one that goes backward for example).
  • Irrelevant QC (claims a block number other than the one claimed in the block header, or mismatching weak/strong claim)
  • Bad QC (signature validation fails)

Note that the last one should fail to replay only if --force-all-checks is not provided. The other two should always fail to replay.

@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Sep 9, 2024
@arhag arhag changed the title Add unit test to verify replay of blocks with bad QC data with --force-all-checks fails Add unit test to verify replay of blocks with bad QC data Sep 9, 2024
@arhag arhag added 👍 lgtm and removed triage labels Sep 9, 2024
@arhag arhag added this to the Spring v1.0.2 milestone Sep 9, 2024
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Sep 11, 2024
@arhag arhag modified the milestones: Spring v1.0.2, Spring v1.0.1 Sep 12, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment