Tool Breaking on Download Samples

[rothoma2]

When trying to run the tool it breaks for me.

I suspect it requires some API Key that is not created on my environment.Which highlights a few issues:

• We need to validate for API keys to exist in ENV, before using a backend.
• Probably need to return earlier, is theres an error with the backend, or expand the try except.
• We need to add a config option, to show people steps on how to get their API keys and set them up.

[poneoneo]

do we have the same api key value ??

[poneoneo]

We need to validate for API keys to exist in ENV, before using a backend.

it's was already did i means this case is already catch.

[poneoneo]

should i track my api-keys to ensure that everyone will have the same ?

[rothoma2]

Im not sure, I follow your last comment. Each person should create and set their own unique API keys locally.

[poneoneo]

oh it's real... btw i found the source of the bug is due to fact that even when we run scrapper to get only malware bazaar files, the script will try to run malshare too . and if api keys for malshare isnt there this cause this errors. cause they are both in the same function

def run_scrapper(args):
    malware_bazaar.scrap_malware_bazaar(args.hundred_recent)
    malshare.scrap_malshare()

[poneoneo]

maybe we should thinking about creating a command to run especially each backend individually and another to run all at once

[poneoneo]

cause when you provide --MwBz_100 you didnt expect to get files from malshare

[rothoma2]

Yeah maybe the logic should be,

1. Default, check all env variables, for each env present trigger the backend. For Env missing do not trigger it. print a warning at the end of backends with no env keys.
2. have an option, where you can add comma separated the names of the backends, and you can select which ones to dowload.

[poneoneo]

i will push another commit that fix this and made another pr to integrate typer and then integrate theses logic.. what do you think about...

[poneoneo]

cause im also want to set a command that will be run without need to run python each time but typer should be install first... then i will add a path to pyproject.toml file to tell with wihich file have a main groups of subcommands. i learn too much on typer while i was building my own package.

[rothoma2]

You can also do this with poetry, you can add entry pointd, to create a cli entry into your application.

[poneoneo]

yes ofcourse typer is not poetry replacement ... but a library to create cli app

[poneoneo]

is a argparse replacement. is just a library that i will add on top of existing dependencies to build commands

[rothoma2]

This seem to be fixed with the Rewrite, I still need to create more API Keys to Test this.