Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controller map image #346

Closed
pktiuk opened this issue Jan 18, 2022 · 3 comments · Fixed by #672
Closed

Update controller map image #346

pktiuk opened this issue Jan 18, 2022 · 3 comments · Fixed by #672
Labels
enhancement New feature or request good first issue Good for newcomers low-priotity

Comments

@pktiuk
Copy link
Member

pktiuk commented Jan 18, 2022

This is how it looks now:

obraz

It would be good to use some SVG image (or maybe something with better defined edges), because this image doesn't look very good with dark themes. (and is a bit outdated - missing share button)

controllermapping

@pktiuk pktiuk added enhancement New feature or request good first issue Good for newcomers low-priotity labels Jan 18, 2022
@pktiuk pktiuk changed the title Replace controller map image Update controller map image Jan 18, 2022
@pktiuk
Copy link
Member Author

pktiuk commented Oct 5, 2022

In this case we should Use a bit different picture this time.
As @Igetin mentioned in #307 (comment)

@pktiuk Can you reopen this issue? SDL does, in fact, support the share button of the controller. The "not recognized by SDL" error message was a red herring, which is caused by the Linux kernel driver translating the share button press into a (non-joypad) key press, resulting in SDL showing both the button press and the error for the unrecognized key press.

AntiMicroX's log output was also lacking because of the kernel driver not directly supporting the button.

As discovered here, AntiMicroX does not recognize the share button because it is not handling the SDL_CONTROLLER_BUTTON_MISC1 button type.

The SDL mapping string looks like this when created with their mapping tool:

050000005e040000130b000007050000,Xbox Series X Controller,platform:Linux,a:b0,b:b1,x:b3,y:b4,back:b10,guide:b12,start:b11,leftstick:b13,rightstick:b14,leftshoulder:b6,rightshoulder:b7,dpup:h0.1,dpdown:h0.4,dpleft:h0.8,dpright:h0.2,misc1:b15,leftx:a0,lefty:a1,rightx:a2,righty:a3,lefttrigger:a5,righttrigger:+a4,

The misc1:b15 part there is the mapping for SDL_CONTROLLER_BUTTON_MISC1.

Another closely related thing: I think the controller mapping dialog of AntiMicroX should be updated to support this additional button as well. The button should be shown in the mapping list and in the controller image.

Here is how SDL's official mapping tool displays it:

Of course, I can make this into a separate issue, if needed.

@Igetin
Copy link

Igetin commented Oct 5, 2022

Feel free to use the following SVG, on which I spent 5 minutes. :P

controller_optimized

Based on this original image.

@pktiuk
Copy link
Member Author

pktiuk commented Oct 5, 2022

Thank you, this will come in handy for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers low-priotity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants