Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize tag structure for Container images and implement in GH Actions #1124

Closed
EricWittmann opened this issue Jan 6, 2021 · 0 comments · Fixed by #1135
Closed

Finalize tag structure for Container images and implement in GH Actions #1124

EricWittmann opened this issue Jan 6, 2021 · 0 comments · Fixed by #1135
Assignees

Comments

@EricWittmann
Copy link
Member

There are two places where we build container images and push them to docker hub and quay:

  • CI builds when a branch changes (master, 1.2.x, etc)
  • CI builds when performing a manual release

In these cases we need to properly tag then container images before pushing them. The GH Actions responsible for the above tasks already do this, but the tags they use are a little confusing. Here we define what tags should be applied in both.

CI Builds for Branch Changes

When doing a CI build due to a change to the branch (e.g. when a change to master is merged from a PR), the following tags should be applied to the container images:

  • When building from the master branch, apply the latest-snapshot
  • When building from a maintenance branch, such as 1.2.x or 1.3.x, apply <branch-name>-snapshot (for example 1.3.x-snapshot)

CI Builds for Release

When doing a CI build due to a manually triggered release, the following tags should be applied to the container images:

  • Apply the specific release version # tag, e.g. 2.0.7.Final
  • When releasing from the master branch, apply latest-release
  • When releasing from a maintenance branch, such as 1.2.x or 1.3.x apply <branch-name>-release (for example 1.3.x-release)
@riprasad riprasad self-assigned this Jan 6, 2021
@riprasad riprasad linked a pull request Jan 13, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants