Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate or remove KafkaRetryTest #1187

Closed
famarting opened this issue Feb 3, 2021 · 2 comments
Closed

Relocate or remove KafkaRetryTest #1187

famarting opened this issue Feb 3, 2021 · 2 comments

Comments

@famarting
Copy link
Contributor

I noticed the KafkaRetryTest in utils/kafka module is waiting up to one minute before it throws TestAbortedException to skip the test...
I wonder if we could relocate the test to the storage/streams or storage/kafkasql modules to ensure it is triggered only when it's expected to be executed, otherwise we are making the rest of the builds much slower.

looks like @alesj wrote that test, what do you think?

@EricWittmann
Copy link
Member

Can we re-implement this test in your integration test suite?

@alesj
Copy link
Contributor

alesj commented Feb 10, 2021

Well, it tests that Kafka util lib ...
(that lib is used in Strimzi as well, etc)

Perhaps just a better / quicker mechanism to see that there is no Kafka running ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants