Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ccompat API should accept both application/vnd.schemaregistry.v1+json and application/json #1449

Closed
EricWittmann opened this issue Apr 21, 2021 · 4 comments
Assignees
Labels
DUPLICATE This issue or pull request already exists

Comments

@EricWittmann
Copy link
Member

Our ccompat API currently accepts application/vnd.schemaregistry.v1+json as the input/output for all JSON based requests. So if a user tries to make a request using Accept: application/json (for example) the request will fail. We should allow both.

@EricWittmann EricWittmann added the type/enhancement New feature or request label Apr 21, 2021
@EricWittmann
Copy link
Member Author

Note: this problem has been reported for version 1.3.2.Final. The report includes this reproducer:

curl -vi -H "Accept: application/json" -H "Content-Type: application/json" http://reg-service-54hv5.schema-registry:8080/api/ccompat/subjects

That will apparently fail. I have not yet tried it to confirm.

@EricWittmann
Copy link
Member Author

It's possible that the problem is adding an Accept header for a GET operation...

@carlesarnal
Copy link
Member

This was reported in the past and has been fixed for versions later than 1.3.2.Final, see #1017.

@EricWittmann
Copy link
Member Author

Yes sorry - closing as duplicate of #1007.

@EricWittmann EricWittmann added DUPLICATE This issue or pull request already exists and removed type/enhancement New feature or request labels Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DUPLICATE This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants