Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serde security properties issues #1455

Closed
tszappanos opened this issue Apr 22, 2021 · 1 comment · Fixed by #1456
Closed

serde security properties issues #1455

tszappanos opened this issue Apr 22, 2021 · 1 comment · Fixed by #1456

Comments

@tszappanos
Copy link

The following configurations do not work through client properties:

  1. In case of setting apicurio.auth.username, apicurio.registry.url is taken into username and vice versa. Correction:
    In the AbstractSchemaResolver class on line 82, the url and username parameters are exchanged

  2. apicurio.auth.client.secret is not considered. The value from apicurio.auth.client.id is set. Correction:
    In the DefaultSchemaResolverConfig class, correct the method

public String getAuthClientSecret () {
return this.getString (AUTH_CLIENT_ID);
}
Well thank you. Tibor

@carlesarnal
Copy link
Member

Hi @tszappanos,

You're right, both are wrong, thanks.

cc @famartinrh

@carlesarnal carlesarnal linked a pull request Apr 22, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants