Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why limit "getArtifactVersionMetaDataByContent" request bodies to application/json? #1476

Closed
kilahm opened this issue May 3, 2021 · 1 comment
Labels
type/bug Something isn't working

Comments

@kilahm
Copy link

kilahm commented May 3, 2021

In attempting to address #1448 locally until @EricWittmann is able to supply an official solution, I saw the getArtifactVersionMetaDataByContent operation requires a body of content type application/json. I can understand this for artifacts whose content is JSON, however I'm not sure how this endpoint would be used for WSDL, GraphQL, XSD, and other artifacts that aren't typically represented with JSON.

Is there a reason to restrict that endpoint to just application/json? AFAICT following the code, the content isn't ever parsed as JSON (in fact, there's one place where the body is converted from YAML to JSON).

@EricWittmann
Copy link
Member

Yeah I noticed this while doing the updates in #1477 and fixed it there. Thanks for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants