Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the federated modules #1564

Closed
EricWittmann opened this issue Jun 11, 2021 · 1 comment
Closed

Improvements to the federated modules #1564

EricWittmann opened this issue Jun 11, 2021 · 1 comment
Assignees

Comments

@EricWittmann
Copy link
Member

  • Pass config via module property
  • Make all federated components .tsx files
  • Clean up config - remove unused properties
  • Pass full registry API url - no need for :tenantId with replacement
  • Stop passing tenantId as property to federated modules
  • Auth will be passed in registry UI config as part of (1) - "token" may be the type
    • the getToken function can be passed as an option?
  • Move federatedmodule config to webpack.common
  • Remove navPathPrefix - use history.createHref() instead
@EricWittmann
Copy link
Member Author

Fixed in #1571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant