Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create parent for storage modules to share #802

Closed
EricWittmann opened this issue Sep 1, 2020 · 5 comments · Fixed by #1391
Closed

Create parent for storage modules to share #802

EricWittmann opened this issue Sep 1, 2020 · 5 comments · Fixed by #1391
Assignees

Comments

@EricWittmann
Copy link
Member

All of the storage maven modules each run the entire suite of Quarkus based integration tests. So the same set of test dependencies is required for all of the storage variants. We should isolate these deps in a BOM so that we only need to keep it updated it one place.

@alesj
Copy link
Contributor

alesj commented Sep 2, 2020

Ah, OK, the approach we have now is good, you would just like to remove the list of deps one needs to copy -- makes sense, if easily doable.

@EricWittmann
Copy link
Member Author

Exactly - would just be nice to maintain the list of test dependencies in one place so when a new dep is needed, we don't have to add it to every storage variant's pom.xml. Should be easy enough. I think @jsenko mentioned he's had some experience creating BOMs.

@EricWittmann
Copy link
Member Author

Rishab - do you have any time to look into this? I can explain more of what this means if needed... I realize details in the description and comments might be a little sparse.

@riprasad
Copy link
Member

riprasad commented Mar 2, 2021

@EricWittmann Sure Eric. I have no prior experience with BOM. Would love to take this up, just require a bit of support.

@EricWittmann
Copy link
Member Author

Great - this is not a high priority, just a nice to have thing. I think a google search for "maven bom" should yield some interesting information.

@riprasad riprasad linked a pull request Mar 10, 2021 that will close this issue
@riprasad riprasad changed the title Create Test BOM for storage modules to share Create parent for storage modules to share Mar 25, 2021
@riprasad riprasad linked a pull request Mar 29, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants