Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<small> text size unaffected by "Base Font Size" feature #197

Open
alinachin opened this issue Jul 1, 2024 · 1 comment
Open

<small> text size unaffected by "Base Font Size" feature #197

alinachin opened this issue Jul 1, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@alinachin
Copy link

Platform

Windows 11

Browser

Firefox 127.0.2 (64-bit)

Addon version

1.1.0

Details

Tumblr post text that's styled with <small> tags stays at 13px, does not increase/decrease in size to follow the base font size set by this extension's "Change Base Font Size" feature.
@alinachin alinachin added the enhancement New feature or request label Jul 1, 2024
@marcustyphoon
Copy link
Collaborator

marcustyphoon commented Jul 1, 2024 •
edited
Loading

Today I learned: the CSS web standard has different keywords called small/large (based only on the user's browser settings) and smaller/larger (scales the way we're doing it). Neat! Kind of confusing!

Arguably would make the most sense for Tumblr's frontend to switch to smaller, but maybe there are caveats to doing that. We could probably override it, alternatively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alinachin @marcustyphoon