Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CursorResponse to PostCursorResponse for consistency #339

Open
DiscoPYF opened this issue Dec 6, 2021 · 2 comments · Fixed by #387
Open

Rename CursorResponse to PostCursorResponse for consistency #339

DiscoPYF opened this issue Dec 6, 2021 · 2 comments · Fixed by #387
Assignees
@tjoubert
Labels
breaking change Identify issues that contain a breaking change for existing consumer code enhancement New feature or request

Comments

@DiscoPYF
Copy link
Collaborator

DiscoPYF commented Dec 6, 2021

CursorResponse doesn't follow the naming we use for all the responses. Renaming it to PostCursorResponse will be more consistent with how other responses are named. I find it is helpful to rename it because my first thought is to declare PostCursorResponse for the return type when calling PostCursorAsync.

This may be a breaking change depending on how the change is implemented, but it would be better to do it before we release v1.
@DiscoPYF DiscoPYF added the enhancement New feature or request label Dec 6, 2021
@DiscoPYF
Copy link
Collaborator Author

DiscoPYF commented Dec 6, 2021

Better to wait for #326 after all.

@tjoubert tjoubert self-assigned this Jun 23, 2022
@tjoubert tjoubert mentioned this issue Jul 1, 2022
Merged
@DiscoPYF DiscoPYF linked a pull request Jul 4, 2022 that will close this issue
Breaking Change: Renamed CursorResponse to PostCursorResponse #387
Merged
@DiscoPYF
Copy link
Collaborator Author

This issue was reverted temporarily in #433

@DiscoPYF DiscoPYF reopened this Oct 18, 2022
@DiscoPYF DiscoPYF added the breaking change Identify issues that contain a breaking change for existing consumer code label Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjoubert tjoubert

Labels
breaking change Identify issues that contain a breaking change for existing consumer code enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@tjoubert @DiscoPYF