Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When connected to file, close the file if done reading it #844

Closed
stasostyk opened this issue Jul 19, 2023 · 0 comments
Closed

When connected to file, close the file if done reading it #844

stasostyk opened this issue Jul 19, 2023 · 0 comments

Comments

@stasostyk
Copy link
Contributor

stasostyk commented Jul 19, 2023

When using a file as a mavlink connection (DFReader_binary), the file is never closed and there is no close method provided. As a result, the file is constantly kept open until the python process entirely ends, which could lead to resource leaks, data corruption, and does not allow for doing other operations on the file.

A close method should be added, and when parsing through all log messages and reaching the end, the file should be closed.

Additionally, the close method should be available to be called at any point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant